chore: Support headers when streaming#358
Merged
jsonbailey merged 2 commits intomainfrom Jan 23, 2026
Merged
Conversation
keelerm84
approved these changes
Jan 23, 2026
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Adds header-aware streaming behavior and tests.
StreamingDataSource, handleon_connectheaders to setenvironment_idand immediately trigger FDv1 fallback whenx-launchdarkly-fd-fallbackistrue; refineon_errorto read headers forenvironment_idand fallback, and propagateenvironment_idin updatesld-eventsourceto2.5.0inlaunchdarkly-server-sdk.gemspecspec/impl/data_system/streaming_headers_spec.rbcovering header extraction and FDv1 fallback on connect/errorWritten by Cursor Bugbot for commit 647aca8. This will update automatically on new commits. Configure here.